On 02/27/2017 02:41 PM, Narcisa Vasile wrote: > Pe 27 feb. 2017 11:21, "Lars-Peter Clausen" <lars@xxxxxxxxxx > <mailto:lars@xxxxxxxxxx>> a scris: >> >> On 02/26/2017 10:59 PM, Narcisa Ana Maria Vasile wrote: >> > The contents of the header file are used only by this single source file >> >> Same here, platform data should stay in its the header file, everything else >> can and should be moved. >> >> > I'm attempting to fix this patch and I want to make sure I understood the > right way to do it. > According to the TODO above the platform data struct, this struct should go > to include/linux/iio. So, is it ok to create a new header file with the > original name (ad9834.h), place the platform data struct inside it and put > this header file into include/linux/iio/frequency folder? > Then, in the C file, I will include this new header, remove the platform > data struct, but keep the defines and state struct. > Same for the other file (ad9832). Moving this file to the regular include file path will only happen when the driver as a whole graduates from the staging part of the kernel. For the time being the file should stay were it is. So basically the patch is file as it is, except that the platform data struct should not be moved over to the C file. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
