Re: [PATCH 1/8] iio: stx104: Set parent device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/02/17 12:58, William Breathitt Gray wrote:
> On Sat, Feb 11, 2017 at 01:34:14PM +0100, Lars-Peter Clausen wrote:
>> Initialize the parent of the IIO device to the device that registered it.
>> This makes sure that the IIO device appears the right level in the device
>> hierarchy.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
Hmm. Took me a few moments to decide whether to push these as fixes or
not.  In the end I concluded that they have always been broken, so whilst
they are clearly a fix we want in, the probably don't need to be rushed
in or applied to old kernels. For drivers that were in this cycle, I
may push them out as straight forward fixes however.

If anyone disagrees then shout quickly!

Applied to the togreg branch of iio.git and pushed out as testing.
>> ---
>> drivers/iio/adc/stx104.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/iio/adc/stx104.c b/drivers/iio/adc/stx104.c
>> index be2de48..2df84fa5 100644
>> --- a/drivers/iio/adc/stx104.c
>> +++ b/drivers/iio/adc/stx104.c
>> @@ -318,6 +318,7 @@ static int stx104_probe(struct device *dev, unsigned int id)
>> 	}
>>
>> 	indio_dev->name = dev_name(dev);
>> +	indio_dev->dev.parent = dev;
>>
>> 	priv = iio_priv(indio_dev);
>> 	priv->base = base[id];
>> -- 
>> 2.1.4
>>
> 
> Acked-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux