Re: [PATCH 2/3 v3] iio: adc: break out common code from SPMI VADC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 21, 2017 at 2:37 PM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> On 17/01/17 14:25, Linus Walleij wrote:
>> The SPMI VADC and the earlier XOADC share a subset of
>> common code, so to be able to use the same code in both
>> drivers, we break out a separate file with the common code,
>> prefix exported functions that are no longer static with
>> qcom_* and bake an object qcom-vadc.o that contains both
>> files: qcom-vadc-common.o and qcom-spmi-vadc.o.
>>
>> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>> Cc: linux-arm-msm@xxxxxxxxxxxxxxx
>> Cc: Ivan T. Ivanov <iivanov.xz@xxxxxxxxx>
>> Cc: Andy Gross <andy.gross@xxxxxxxxxx>
>> Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
>> Cc: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
>> Cc: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
>> Cc: Rama Krishna Phani A <rphani@xxxxxxxxxxxxxx>
>> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> This looks like fairly straight forward refacting to me.  Rama, could you
> take a look at this and perhaps test that no breakage has slipped in?
>
> I'd like at least one tested-by on this for the previously supported parts
> (that could be Linus if he has one!)

I am waiting for a serial cable for the APQ8064 Nexus 7 so no
test base so far. I would have to rely on Björn for this.

I think this patch is safe to merge though.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux