Re: [PATCH] iio: health: max30100: fixed parenthesis around FIFO count check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 21, 2017 at 6:18 AM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> On 17/01/17 02:04, Matt Ranostay wrote:
>> FIFO was being read every sample after the "almost full" state was
>> reached. This was due to an incorrect placement of the parenthesis
>> in the while condition check.
>>
>> Signed-off-by: Matt Ranostay <matt@ranostay.consulting>
> Fixes tags please in future.  I've applied this to the fixes-togreg
> branch and marked for stable with a fixes tag of the last patch to
> touch that line (which isn't really correct, but a backport would require
> that patch anyway in addition to this one).

Oops. Note taken.

>
> Jonathan
>> ---
>>  drivers/iio/health/max30100.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/health/max30100.c b/drivers/iio/health/max30100.c
>> index 90ab8a2d2846..183c14329d6e 100644
>> --- a/drivers/iio/health/max30100.c
>> +++ b/drivers/iio/health/max30100.c
>> @@ -238,7 +238,7 @@ static irqreturn_t max30100_interrupt_handler(int irq, void *private)
>>
>>       mutex_lock(&data->lock);
>>
>> -     while (cnt || (cnt = max30100_fifo_count(data) > 0)) {
>> +     while (cnt || (cnt = max30100_fifo_count(data)) > 0) {
>>               ret = max30100_read_measurement(data);
>>               if (ret)
>>                       break;
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux