On 10/01/17 14:21, jic23@xxxxxxxxxx wrote: > On 10.01.2017 08:54, Linus Walleij wrote: >> On Fri, Dec 30, 2016 at 8:01 PM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote: >>> On 15/12/16 22:48, Linus Walleij wrote: >>>> The SPMI VADC and the earlier XOADC share a subset of >>>> common code, so to be able to use the same code in both >>>> drivers, we break out a separate file with the common code, >>>> prefix exported functions that are no longer static with >>>> qcom_* and bake an object qcom-vadc.o that contains both >>>> files: qcom-vadc-common.o and qcom-spmi-vadc.o. >>>> >>>> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx >>>> Cc: linux-arm-msm@xxxxxxxxxxxxxxx >>>> Cc: Ivan T. Ivanov <iivanov.xz@xxxxxxxxx> >>>> Cc: Andy Gross <andy.gross@xxxxxxxxxx> >>>> Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> >>>> Cc: Stephen Boyd <sboyd@xxxxxxxxxxxxxx> >>>> Cc: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> >>>> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> >>> >>> Looks superficially fine, but I'm guessing will need a respin >>> as we have a fair bit of new stuff (and a couple of fixes) going >>> through this driver at the moment. >>> >>> All but the two fixes I posted a few mins ago are in my testing >>> branch and should go to Greg once I have confirmed testing on >>> those two fixes. >> >> I looked at the git and "testing" >> contains a top commit named "guessing" fixing some 64bit >> artithmetic (which looks correct) in the driver, shall I simply >> rebase on top of that and hope for the best? :) > I'm an idiot and pushed out the wrong branch. Will fix up when > I get home and push one with a sensible patch title! > (It'll be the same content though - feel free to Ack that if > you like ;) > > Not my best half asleep patch writing ;) Fixed... It's called testing for a reason ;) Jonathan > > Jonathan >> >> Yours, >> Linus Walleij >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
