On 07/01/17 04:23, Daniel Baluta wrote:
> Hi rishabh,
>
> Congrats on reaching that far on Eudyptula challenge.
> Anyhow, you should write a proper commit message to this patch.
>
> The subject should briefly describe why the patch is needed.
>
> E.g: iio:trigger: Fix coding style
>
> What actually has been fixed and how did you find it. (I assume you
> used checkpatch.pl)
>
> Daniel.
Thanks Daniel, just what I was going to say!
Can't take a patch with a title that doesn't summarize what it is doing.
Jonathan
>
>
> On Fri, Jan 6, 2017 at 11:39 AM, rishabh hardas
> <rishabheudyptula@xxxxxxxxx> wrote:
>> Signed-off-by: rishabh hardas <rishabheudyptula@xxxxxxxxx>
>> ---
>> drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
>> index 38dca69..9658f20 100644
>> --- a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
>> +++ b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
>> @@ -133,7 +133,7 @@ static ssize_t iio_bfin_tmr_frequency_show(struct device *dev,
>> return sprintf(buf, "%lu\n", val);
>> }
>>
>> -static DEVICE_ATTR(frequency, S_IRUGO | S_IWUSR, iio_bfin_tmr_frequency_show,
>> +static DEVICE_ATTR(frequency, 0644, iio_bfin_tmr_frequency_show,
>> iio_bfin_tmr_frequency_store);
>>
>> static struct attribute *iio_bfin_tmr_trigger_attrs[] = {
>> --
>> 2.7.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
