On 30/11/16 15:24, Amit Kumar Kushwaha wrote: > This patch fixes the following checkpatch.pl warning in ad7150.c > WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred > Occured during build. > > Signed-off-by: Amit Kushwaha <kushwaha.a@xxxxxxxxxxx> I'm not overly fussed about these (and generally believe the churn isn't worth the 'really minor' improvement in readability...) Also for some reason it didn't apply. I've done it manually... Anyhow, applied to the togreg branch of iio.git just so I don't get any more emails about it... Jonathan > --- > drivers/staging/iio/cdc/ad7150.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c > index 5578a07..9ab00c0 100644 > --- a/drivers/staging/iio/cdc/ad7150.c > +++ b/drivers/staging/iio/cdc/ad7150.c > @@ -414,7 +414,7 @@ static ssize_t ad7150_store_timeout(struct device *dev, > > #define AD7150_TIMEOUT(chan, type, dir, ev_type, ev_dir) \ > IIO_DEVICE_ATTR(in_capacitance##chan##_##type##_##dir##_timeout, \ > - S_IRUGO | S_IWUSR, \ > + 0644, \ > &ad7150_show_timeout, \ > &ad7150_store_timeout, \ > IIO_UNMOD_EVENT_CODE(IIO_CAPACITANCE, \ > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
