On 10/25/2016 06:57 PM, Jonathan Cameron wrote: > On 24/10/16 16:22, Arnd Bergmann wrote: >> The ad5933_i2c_read function returns an error code to indicate >> whether it could read data or not. However ad5933_work() ignores >> this return code and just accesses the data unconditionally, >> which gets detected by gcc as a possible bug: >> >> drivers/staging/iio/impedance-analyzer/ad5933.c: In function 'ad5933_work': >> drivers/staging/iio/impedance-analyzer/ad5933.c:649:16: warning: 'status' may be used uninitialized in this function [-Wmaybe-uninitialized] >> >> This adds minimal error handling so we only evaluate the >> data if it was correctly read. >> >> Link: https://patchwork.kernel.org/patch/8110281/ >> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > Looks good to me. > > Lars? > Looks good, thanks. Acked-by: Lars-Peter Clausen <lars@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
