PTR_ERR should access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci CC: Tomas Novotny <tomas@xxxxxxxxxx> Signed-off-by: Julia Lawall <julia.lawall@xxxxxxx> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx> --- Please take the patch only if it's a positive warning. Thanks! Not checked at all. This is being reported on the following tree: tree: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git testing head: 2796a310d462f73954c0ce8ffabaf4baacaecca1 commit: e0b80def1faa901d83a7d580e8aa4ad4a512bedf [109/113] iio: dac: mcp4725: support voltage reference selection :::::: branch date: 2 hours ago :::::: commit date: 2 hours ago mcp4725.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/iio/dac/mcp4725.c +++ b/drivers/iio/dac/mcp4725.c @@ -418,7 +418,7 @@ static int mcp4725_probe(struct i2c_clie if (pdata->use_vref) { data->vref_reg = devm_regulator_get(&client->dev, "vref"); if (IS_ERR(data->vref_reg)) { - err = PTR_ERR(data->vdd_reg); + err = PTR_ERR(data->vref_reg); goto err_disable_vdd_reg; } -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
