Re: [PATCH] iio: adc: ti-adc081c: Select IIO_TRIGGERED_BUFFER to prevent build errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 09, 2016 at 08:47:11AM +0100, Jonathan Cameron wrote:
On 05/10/16 15:46, Mika Westerberg wrote:
Commit 08e05d1fce5c ("ti-adc081c: Initial triggered buffer support") added
triggered buffer support but that also requires CONFIG_IIO_TRIGGERED_BUFFER,
otherwise we get errors from linker such as:

  drivers/built-in.o: In function `adc081c_remove':
  drivers/iio/adc/ti-adc081c.c:225: undefined reference to `iio_triggered_buffer_cleanup'

Fix these by explicitly selecting both CONFIG_IIO_TRIGGERED_BUFFER and
CONFIG_IIO_BUFFER in Kconfig for the driver.

Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
Applied to the fixes-togreg-post-rc1 branch of iio.git which I'll send
a pull request for once the merge window is closed. Strange this one
got through the autobuilders (less strange that it snuck past me
reviewing it ;(

Fengguang, any thoughts?

Sorry I find no log for that error and noticed 08e05d1fce5c is half
year old which is not contained in any recent updated trees. Many
things could have been changed/fixed during the time -- if you look at

https://lists.01.org/pipermail/kbuild-all/2016-May/thread.html

There are significant less error reports in May, which probably
impacts late April as well -- at the time the commit is introduced.
Then the problems are discovered and the report number is restored to
over 1000 in June.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux