Re: [PATCH 04/18] staging:iio:accel:sca3000 Fix clearing of flag + setting of size of scan.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 4 October 2016 09:59:51 BST, Lars-Peter Clausen <lars@xxxxxxxxxx> wrote:
>On 10/03/2016 09:26 PM, Jonathan Cameron wrote:
>> diff --git a/drivers/staging/iio/accel/sca3000.c
>b/drivers/staging/iio/accel/sca3000.c
>> index 36a52d02ee0e..8af7d83e658d 100644
>> --- a/drivers/staging/iio/accel/sca3000.c
>> +++ b/drivers/staging/iio/accel/sca3000.c
>> @@ -1491,6 +1491,19 @@ error_ret:
>>   **/
>>  static int sca3000_hw_ring_preenable(struct iio_dev *indio_dev)
>>  {
>> +	/*
>> +	 * Set stuff to read to indicate no data present.
>> +	 * Need for cases where the interrupt had fired at the
>> +	 * end of a cycle, but the data was never read.
>> +	 */
>> +	indio_dev->buffer->stufftoread = 0;
>> +	/*
>> +	 * Needed to ensure the core will actually read data
>> +	 * from the device rather than assuming no channels
>> +	 * are enabled.
>> +	 */
>> +	indio_dev->buffer->bytes_per_datum = 6;
>> +
>
>Shouldn't this be dropped again when switching to kfifo for the buffer?
Good point...

J
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>the body of a message to majordomo@xxxxxxxxxxxxxxx
>More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux