On Sat, Oct 01, 2016 at 04:34:18PM +0530, sayli karnik wrote: > Fix the following sparse warning due to incorrect type in assignment: > drivers/iio/imu/bmi160/bmi160_core.c:411:26: warning: incorrect type > in assignment (different base types) > > drivers/iio/imu/bmi160/bmi160_core.c:411:26: expected signed short > [signed] [short] [explicitly-signed] <noident> > drivers/iio/imu/bmi160/bmi160_core.c:411:26: got restricted __le16 > [addressable] [usertype] sample > > Signed-off-by: sayli karnik <karniksayli1995@xxxxxxxxx> Hi Sayli, Please claim this via the outreachy task page - section endianness coding task. Perhaps you can update the commit msg & changelog with the cosmetic vs bug impact statement as in your earlier patch. question inline below > --- > drivers/iio/imu/bmi160/bmi160_core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/imu/bmi160/bmi160_core.c b/drivers/iio/imu/bmi160/bmi160_core.c > index e0251b8..5355507 100644 > --- a/drivers/iio/imu/bmi160/bmi160_core.c > +++ b/drivers/iio/imu/bmi160/bmi160_core.c > @@ -398,7 +398,8 @@ static irqreturn_t bmi160_trigger_handler(int irq, void *p) > struct iio_poll_func *pf = p; > struct iio_dev *indio_dev = pf->indio_dev; > struct bmi160_data *data = iio_priv(indio_dev); > - s16 buf[16]; /* 3 sens x 3 axis x s16 + 3 x s16 pad + 4 x s16 tstamp */ > + __le16 buf[16]; > + /* 3 sens x 3 axis x __le16 + 3 x __le16 pad + 4 x __le16 tstamp */ > int i, ret, j = 0, base = BMI160_REG_DATA_MAGN_XOUT_L; > __le16 sample; Wondering about this option below. Data was read into an __le16, so that was good diligence on drivers part. Seems we can use le16_to_cpu() for the conversion into the buf. --- a/drivers/iio/imu/bmi160/bmi160_core.c +++ b/drivers/iio/imu/bmi160/bmi160_core.c @@ -408,7 +408,7 @@ static irqreturn_t bmi160_trigger_handler(int irq, void *p) &sample, sizeof(__le16)); if (ret < 0) goto done; - buf[j++] = sample; + buf[j++] = le16_to_cpu(sample); } iio_push_to_buffers_with_timestamp(indio_dev, buf, alisons > > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxx. > To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxx. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161001110418.GA25515%40sayli-HP-15-Notebook-PC. > For more options, visit https://groups.google.com/d/optout. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
