Re: [PATCH] drivers: iio: dac: Fix sparse warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23/09/16 20:20, Sandhya Bankar wrote:
> Fixing below warnings:
> 
> drivers/iio/dac/ad5592r.c:58:41: warning: incorrect type in argument 2 (different base types)
> drivers/iio/dac/ad5592r.c:58:41:    expected unsigned short [usertype] *buf
> drivers/iio/dac/ad5592r.c:58:41:    got restricted __be16 *<noident>
> drivers/iio/dac/ad5592r.c:62:41: warning: incorrect type in argument 2 (different base types)
> drivers/iio/dac/ad5592r.c:62:41:    expected unsigned short [usertype] *buf
> drivers/iio/dac/ad5592r.c:62:41:    got restricted __be16 *<noident>
> drivers/iio/dac/ad5592r.c:92:41: warning: incorrect type in argument 2 (different base types)
> drivers/iio/dac/ad5592r.c:92:41:    expected unsigned short [usertype] *buf
> drivers/iio/dac/ad5592r.c:92:41:    got restricted __be16 *<noident>
> drivers/iio/dac/ad5592r.c:110:41: warning: incorrect type in argument 2 (different base types)
> drivers/iio/dac/ad5592r.c:110:41:    expected unsigned short [usertype] *buf
> drivers/iio/dac/ad5592r.c:110:41:    got restricted __be16 *<noident>
> 
> Signed-off-by: Sandhya Bankar <bankarsandhya512@xxxxxxxxx>
Looks good to me.  Lars, will be a while before I send next pull if
you want to comment on this as well.

Applied to the togreg branch of iio.git -- initially pushed out as
testing for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/dac/ad5592r.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/ad5592r.c b/drivers/iio/dac/ad5592r.c
> index 0b235a2..6eed5b7 100644
> --- a/drivers/iio/dac/ad5592r.c
> +++ b/drivers/iio/dac/ad5592r.c
> @@ -17,7 +17,7 @@
>  #define AD5592R_GPIO_READBACK_EN	BIT(10)
>  #define AD5592R_LDAC_READBACK_EN	BIT(6)
>  
> -static int ad5592r_spi_wnop_r16(struct ad5592r_state *st, u16 *buf)
> +static int ad5592r_spi_wnop_r16(struct ad5592r_state *st, __be16 *buf)
>  {
>  	struct spi_device *spi = container_of(st->dev, struct spi_device, dev);
>  	struct spi_transfer t = {
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux