On 23/09/16 21:04, Sandhya Bankar wrote: > Fixing below warning: > drivers/iio/adc/max1027.c:241:34: warning: dubious: x | !y . > > Signed-off-by: Sandhya Bankar <bankarsandhya512@xxxxxxxxx> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > Changes in v2: > * Using MAX1027_TEMP instead of number. > > drivers/iio/adc/max1027.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c > index 712fbd2..d601818 100644 > --- a/drivers/iio/adc/max1027.c > +++ b/drivers/iio/adc/max1027.c > @@ -238,7 +238,9 @@ static int max1027_read_single_value(struct iio_dev *indio_dev, > > /* Configure conversion register with the requested chan */ > st->reg = MAX1027_CONV_REG | MAX1027_CHAN(chan->channel) | > - MAX1027_NOSCAN | !!(chan->type == IIO_TEMP); > + MAX1027_NOSCAN; > + if (chan->type == IIO_TEMP) > + st->reg |= MAX1027_TEMP; > ret = spi_write(st->spi, &st->reg, 1); > if (ret < 0) { > dev_err(&indio_dev->dev, > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html