On 09/23/2016 08:13 AM, Sandhya Bankar wrote: > Fixing below warning: > drivers/iio/adc/max1027.c:241:34: warning: dubious: x | !y . > > Signed-off-by: Sandhya Bankar <bankarsandhya512@xxxxxxxxx> Hi, Thanks for the patch. Looks good in general, just one minor detail > --- > drivers/iio/adc/max1027.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c > index 712fbd2..b1fee47 100644 > --- a/drivers/iio/adc/max1027.c > +++ b/drivers/iio/adc/max1027.c > @@ -238,7 +238,9 @@ static int max1027_read_single_value(struct iio_dev *indio_dev, > > /* Configure conversion register with the requested chan */ > st->reg = MAX1027_CONV_REG | MAX1027_CHAN(chan->channel) | > - MAX1027_NOSCAN | !!(chan->type == IIO_TEMP); > + MAX1027_NOSCAN; > + if (chan->type == IIO_TEMP) > + st->reg |= 1; The driver has a symbolic constant defined for this 'MAX1027_TEMP'. Using this instead of the number makes it clear what the semantic meaning of the value is. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
