On 14 September 2016 06:59:23 BST, Ico Doornekamp <ico@xxxxxxxx> wrote: >* On 2016-09-13 19:35:28 +0200, Jonathan Cameron wrote: > >> Other than one big issue, the patch looks very good. >> >> You actually need to add this entry to one of the info_mask bitmaps >to >> have the attributes instantiated. > >I suspected as much, but I wasn't quite sure about the semantics of the >fields, and when to use info_mask_shared_by_type vs >info_mask_shared_by_all. Here we have existing correct ABI to userspace so we should stick to what is present. Shared by all will keep naming as simply sampling_frequency. J -- Sent from my Android device with K-9 Mail. Please excuse my brevity. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html