On 09/09/16 14:59, Lars-Peter Clausen wrote: > Hi, > > Thanks for the patch. But this not a correct change, it is a false positive > reported by checkpatch. Just to explain a bit more. Checkpatch is assuming that it is looking at two parameters. It's not. That's a string being passed into the macro. It ultimately forms a file name in sysfs. Jonathan p.s. We get patches for this from time to time ;( Unfortunately it's a somewhat obscure case for checkpatch. > > - Lars > > On 09/09/2016 03:40 PM, Ico Doornekamp wrote: >> --- >> drivers/staging/iio/adc/ad7192.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c >> index 1cf6b79..5688b29 100644 >> --- a/drivers/staging/iio/adc/ad7192.c >> +++ b/drivers/staging/iio/adc/ad7192.c >> @@ -391,7 +391,7 @@ ad7192_show_scale_available(struct device *dev, >> } >> >> static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available, >> - in_voltage-voltage_scale_available, >> + in_voltage - voltage_scale_available, >> S_IRUGO, ad7192_show_scale_available, NULL, 0); >> >> static IIO_DEVICE_ATTR(in_voltage_scale_available, S_IRUGO, >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
