Re: [PATCH 15/15 v2] iio: accel: kxsd9: Support reading a mounting matrix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/09/16 10:44, Linus Walleij wrote:
> This adds support for the mounting matrix to the KXSD9 driver.
> 
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Well the identity matrix is nicely reported by my pre device tree
board.

(yeah I know I could make it run off device tree but somehow
it's never high on my list given I don't actually know of anyone
other than me who still uses these ;)

So I'll give it a 
Tested-by: Jonathan Cameron <jic23@xxxxxxxxxx>

So all now tested as well as I'm going to on real hardware.
No crashes and data is just as rubbish as I remember..

Will pick up once the fixes make it through.  Could
conceivably not happen until after merge window. We will
have to see.


Jonathan
> ---
> ChangeLog v1->v2:
> - Rebase on the rest of the series.
> ---
>  drivers/iio/accel/kxsd9.c | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/drivers/iio/accel/kxsd9.c b/drivers/iio/accel/kxsd9.c
> index a28163b76e12..9af60ac70738 100644
> --- a/drivers/iio/accel/kxsd9.c
> +++ b/drivers/iio/accel/kxsd9.c
> @@ -68,12 +68,14 @@
>   * struct kxsd9_state - device related storage
>   * @dev: pointer to the parent device
>   * @map: regmap to the device
> + * @orientation: mounting matrix, flipped axis etc
>   * @regs: regulators for this device, VDD and IOVDD
>   * @scale: the current scaling setting
>   */
>  struct kxsd9_state {
>  	struct device *dev;
>  	struct regmap *map;
> +	struct iio_mount_matrix orientation;
>  	struct regulator_bulk_data regs[2];
>  	u8 scale;
>  };
> @@ -258,6 +260,20 @@ static const struct iio_buffer_setup_ops kxsd9_buffer_setup_ops = {
>  	.postdisable = kxsd9_buffer_postdisable,
>  };
>  
> +static const struct iio_mount_matrix *
> +kxsd9_get_mount_matrix(const struct iio_dev *indio_dev,
> +		       const struct iio_chan_spec *chan)
> +{
> +	struct kxsd9_state *st = iio_priv(indio_dev);
> +
> +	return &st->orientation;
> +}
> +
> +static const struct iio_chan_spec_ext_info kxsd9_ext_info[] = {
> +	IIO_MOUNT_MATRIX(IIO_SHARED_BY_TYPE, kxsd9_get_mount_matrix),
> +	{ },
> +};
> +
>  #define KXSD9_ACCEL_CHAN(axis, index)						\
>  	{								\
>  		.type = IIO_ACCEL,					\
> @@ -266,6 +282,7 @@ static const struct iio_buffer_setup_ops kxsd9_buffer_setup_ops = {
>  		.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),		\
>  		.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE) |	\
>  					BIT(IIO_CHAN_INFO_OFFSET),	\
> +		.ext_info = kxsd9_ext_info,				\
>  		.address = KXSD9_REG_##axis,				\
>  		.scan_index = index,					\
>  		.scan_type = {                                          \
> @@ -403,6 +420,13 @@ int kxsd9_common_probe(struct device *dev,
>  	indio_dev->modes = INDIO_DIRECT_MODE;
>  	indio_dev->available_scan_masks = kxsd9_scan_masks;
>  
> +	/* Read the mounting matrix, if present */
> +	ret = of_iio_read_mount_matrix(dev,
> +				       "mount-matrix",
> +				       &st->orientation);
> +	if (ret)
> +		return ret;
> +
>  	/* Fetch and turn on regulators */
>  	st->regs[0].supply = kxsd9_reg_vdd;
>  	st->regs[1].supply = kxsd9_reg_iovdd;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux