On 07/03/2016 01:17 PM, Jonathan Cameron wrote: > On 28/06/16 09:18, Quentin Schulz wrote: >> The Allwinner SoCs all have an ADC that can also act as a touchscreen >> controller and a thermal sensor. For now, only the ADC and the thermal >> sensor drivers are probed by the MFD, the touchscreen controller support >> will be added later. >> >> Signed-off-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxx> > The code looks fine to me. The 'controversial' bit of this is listing > iio-hwmon as an mfd child to get it to probe as a result of this being > present. My immediately thought is that it should be separately > described in the devicetree and hence instantiated outside of this driver. The devicetree is a generic description of the hardware. The iio-hwmon bridge is a software component that translates between two Linux specific ABIs. In my opinion putting the later in the former is makes no sense, it is simply not part of the hardware description. Its quite terrible that we have the bindings in the first place, but I guess we have to keep them considering they are ABI and there are existing users. But we should definitely strongly discourage the introduction of new users. It is policy whether an application wants to access a device using the IIO or hwmon API. As such it must be managed by userspace, this is not something that can be done using devicetree nor should it be something that is done on a driver by driver basis. - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
