Re: [PATCH 5/6 v3] iio: magn: ak8975: make sure to power down at remove()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 29 June 2016 at 14:08, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> The code was not powering the magnetometer down properly at
> remove(): just cutting the regulators without first setting the
> device in power off mode. Fix this.
>
> Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Reviewed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>

Kind regards
Uffe

> ---
> ChangeLog v2->v3:
> - Rebase
> ChangeLog v1->v2:
> - New patch in the series after Ulf's review comment that this
>   should be separate.
> ---
>  drivers/iio/magnetometer/ak8975.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
> index c67cf3a6128d..43dc1c74be9e 100644
> --- a/drivers/iio/magnetometer/ak8975.c
> +++ b/drivers/iio/magnetometer/ak8975.c
> @@ -990,6 +990,7 @@ static int ak8975_remove(struct i2c_client *client)
>
>         iio_device_unregister(indio_dev);
>         iio_triggered_buffer_cleanup(indio_dev);
> +       ak8975_set_mode(data, POWER_DOWN);
>         ak8975_power_off(data);
>
>         return 0;
> --
> 2.4.11
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux