Re: [PATCH 1/3] iio: potentiometer: mcp4531: Add support for MCP454x, MCP456x, MCP464x and MCP466x

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On 06/21/2016 09:04 AM, Peter Meerwald-Stadler wrote:
> 
>> @@ -49,8 +49,10 @@ config MCP4531
>>  	depends on I2C
>>  	help
>>  	  Say yes here to build support for the Microchip
>> -	  MCP4531, MCP4532, MCP4551, MCP4552,
>> -	  MCP4631, MCP4632, MCP4651, MCP4652
>> +	  MCP4531, MCP4532, MCP4541, MCP4542,
>> +	  MCP4551, MCP4552, MCP4561, MCP4562,
>> +	  MCP4631, MCP4632, MCP4641, MCP4642,
>> +	  MCP4651, MCP4652, MCP4661, MCP4662
>>  	  digital potentiomenter chips.
> 
> unrelated typo: potentiometer
> could you please fix it up as a separate patch in you series?
> 

Sure, I will do this patch in v2.

> some whitespace around /*sentinel*/ in patch 3/3 would be nice, looks good 
> otherwise

I will wait for some more feedback and fix in v2.

Thanks for your review,
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux