Re: [RFC PATCH v1 0/9] iio:st_sensors: fixes and lps22hb pressure sensor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/11/2016 07:36 PM, Jonathan Cameron wrote:
On 19/04/16 10:18, Gregor Boirie wrote:
This preliminary patch series adds support for a new ST LPS22HB pressure sensor
and introduce a few fixes related to st_pressure core and st_sensors triggered
buffering.
It is not meant to be reviewed for definitive inclusion as it touches too many
drivers / devices I cannot test with.
Note that as a few minor and more controversial patches (7, 8 and 9) might also
be candidate for a seperate series.

Patch 2 makes st_pressure sensors compliant with ABI and fixes a few missing
sampling gains. Scale / offset computation is modified to address all gains
currently possible. It impacts LPS331AP, LPS001WP and LPS25H sensors.
Please please please ! If anyone owning one of these could run some tests, I'd
be glad to get some feedback since I have none of them.

Patch 4 is a rework of the way st_sensors samples are stored in memory to comply
with IIO expected alignment contraints (some st_pressure samples are 24 bits
long). It is heavily based upon Linux Walleij' approach where each channel is
captured individually. See http://www.spinics.net/lists/linux-iio/msg24028.html
and http://www.spinics.net/lists/linux-iio/msg23598.html threads for more infos.
This patch impacts all st_sensors.
Please please please ! If anyone owning one of these could run some tests...

Patch 5 enforces 32 bits storage alignment for 24 bits long st_pressure
sampling channels.
Patch 6 enables triggered buffering for st_pressure temperature channels. We
need temperature samples to control on-board device temperature (noise and
drift removal).
Both patches impact st_pressure sensors mentionned above. Please please please !
If anyone owning one of these could run some tests...

Regards,
gregor.

Hi Gregor,
Hi everybody,

getting back to life...
This series has now drifted out of my active list. Hope you get time
to respond to the various minor issues as would be great to get the
remainder of these in place!

Not to worry if it will be a while.
I'll have some time to rebase the whole stuff and take your comments into account next week. Anyway, the good point is that the delay prevented me from conflicting with Linus' upstreaming work on
triggered buffering machinery :)
Stay tuned.

Regards,
Grégor

Thanks,

Jonathan
Gregor Boirie (9):
   iio:st_pressure:initial lps22hb sensor support
   iio:st_pressure: fix sampling gains
   iio:st_pressure: lps22hb temperature support
   iio:st_sensors: align on storagebits boundaries
   iio:st_pressure: align storagebits on power of 2
   iio:st_pressure: temperature triggered buffering
   iio:st_sensors: unexport st_sensors_get_buffer_element
   iio:st_sensors: emulate SMBus block read if needed
   iio:st_sensors: fix power regulator usage

  .../devicetree/bindings/iio/st-sensors.txt         |   1 +
  drivers/iio/accel/st_accel_core.c                  |  12 +-
  drivers/iio/common/st_sensors/st_sensors_buffer.c  |  41 ++--
  drivers/iio/common/st_sensors/st_sensors_core.c    |  31 ++-
  drivers/iio/common/st_sensors/st_sensors_i2c.c     |   4 +-
  drivers/iio/gyro/st_gyro_core.c                    |  12 +-
  drivers/iio/magnetometer/st_magn_core.c            |  12 +-
  drivers/iio/pressure/Kconfig                       |   2 +-
  drivers/iio/pressure/st_pressure.h                 |   1 +
  drivers/iio/pressure/st_pressure_core.c            | 250 ++++++++++++++++-----
  drivers/iio/pressure/st_pressure_i2c.c             |   4 +
  drivers/iio/pressure/st_pressure_spi.c             |   1 +
  include/linux/iio/common/st_sensors.h              |   4 +-
  13 files changed, 278 insertions(+), 97 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux