On Fri, Jun 3, 2016 at 7:42 PM, William Breathitt Gray
<vilhelm.gray@xxxxxxxxx> wrote:
> The Apex Embedded Systems STX104 device features eight lines of digital
> I/O (four digital inputs and four digital outputs). This patch adds GPIO
> support for these eight lines of digital I/O via GPIOLIB.
>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx>
> ---
> Changes in v2:
> - Change GPIOLIB Kconfig selection to a dependency for the STX104 Kconfig
> option; STX104 should only be available to systems configured for GPIOLIB
Are you sure? I just changed the GPIOLIB Kconfig so any arch/thing can
select GPIOLIB, if this driver needs it, it can just select it now.
> +static int stx104_gpio_get_direction(struct gpio_chip *chip,
> + unsigned int offset)
> +{
> + if (offset < 4)
> + return 1;
> +
> + return 0;
> +}
If this looks so...
> +static int stx104_gpio_direction_input(struct gpio_chip *chip,
> + unsigned int offset)
> +{
> + return 0;
> +}
> +
> +static int stx104_gpio_direction_output(struct gpio_chip *chip,
> + unsigned int offset, int value)
> +{
> + return 0;
> +}
These should return -EINVAL or -EIO or something if you try to
set the direction to something the line does not support.
Other than that it looks good.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
