RE: [PATCH] iio: (ms5637) Add Measurement Specialties explicit MS5805 and MS5837 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 31 May 2016, Markezana, William wrote:

> Signed-off-by: William Markezana <william.markezana@xxxxxxxxxxxxx>
> ---
>  drivers/iio/pressure/ms5637.c | 20 +++++++++++++++++---
>  1 file changed, 17 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/pressure/ms5637.c 
> b/drivers/iio/pressure/ms5637.c index e8d0e0d..6ecc686 100644
> --- a/drivers/iio/pressure/ms5637.c
> +++ b/drivers/iio/pressure/ms5637.c
> @@ -1,5 +1,6 @@
>  /*
> - * ms5637.c - Support for Measurement-Specialties ms5637 and ms8607
> + * ms5637.c - Support for Measurement-Specialties ms5637, ms8607,
> +              ms5805 and ms5837

I guess we expect it to look like
 *             ms5805 and ms5837 pressure & temperature sensors

and I suggest to list the chips in lexicographic order (here and all other
lists)

-I will update the patch according to you suggestion.

it seems there is no functional difference?

-All sensors are different and have various measurement range. 
This patch is about making people aware that this driver is compatible 
with other sensors without duplicating code. 
Is there a better way to do that ?

>   *            pressure & temperature sensor
>   *
>   * Copyright (c) 2015 Measurement-Specialties @@ -12,6 +13,10 @@
>   *  http://www.meas-spec.com/downloads/MS5637-02BA03.pdf
>   * Datasheet:
>   *  http://www.meas-spec.com/downloads/MS8607-02BA01.pdf
> + * Datasheet:
> + *  http://www.meas-spec.com/downloads/MS5805-02BA01.pdf
> + * Datasheet:
> + *  http://meas-spec.com/downloads/MS5837-30BA.pdf
>   */
>  
>  #include <linux/init.h>
> @@ -26,6 +31,13 @@
>  
>  #include "../common/ms_sensors/ms_sensors_i2c.h"
>  
> +enum {
> +	MS5637,
> +	MS8607,
> +	MS5805,
> +	MS5837
> +};
> +
>  static const int ms5637_samp_freq[6] = { 960, 480, 240, 120, 60, 30 
> };
>  /* String copy of the above const for readability purpose */  static 
> const char ms5637_show_samp_freq[] = "960 480 240 120 60 30"; @@ 
> -169,8 +181,10 @@ static int ms5637_probe(struct i2c_client *client,  
> }
>  
>  static const struct i2c_device_id ms5637_id[] = {
> -	{"ms5637", 0},
> -	{"ms8607-temppressure", 1},
> +	{"ms5637", MS5637},
> +	{"ms8607-temppressure", MS8607},
> +	{"ms5805", MS5805},
> +	{"ms5837", MS5837},
>  	{}
>  };
>  
> 

-- 

Peter Meerwald-Stadler
+43-664-2444418 (mobile)
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux