On Wed, May 4, 2016 at 9:35 AM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > On 03/05/16 21:10, Linus Walleij wrote: >>> Even with hardware triggers: are you sure this is correct? Shouldn't >>> iio_trigger_notify_done still get called even when there is nothing to do? >> >> No then the (hardware) IRQ can have come in from some other >> device sharing the line with the peripheral and we need to return >> IRQ_NONE. It's not our interrupt. > > Gah, I fouled up reviewing this. We really need to know if it is our > trigger 'before' we fire off the trigger logic - any number of other > devices can in theory be hanging off a given trigger - none of them will > be able to know if it was a real trigger or not. Ooops sorry, but the good thing is: we get to properly fix it. > What we need to do is work out how to elegantly fall back to > not running top halves of triggers if we are coming from threaded > context. I'm looking into this. Pretty complex, but certainly doable. As we're not even in the merge window yet I bet we can cook up a proper solution instead of dirty hacks. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
