On Tue, May 3, 2016 at 1:43 PM, Jonathan Cameron <jic23@xxxxxxxxxxxxxxxxxxxxx> wrote: > > > On 3 May 2016 09:29:26 CEST, Daniel Baluta <daniel.baluta@xxxxxxxxx> wrote: >>On Sun, May 1, 2016 at 9:56 PM, Jonathan Cameron <jic23@xxxxxxxxxx> >>wrote: >>> On 29/04/16 13:19, Constantin Musca wrote: >>>> Minimal implementation of an IIO driver for the Freescale >>>> MMA7660FC 3-axis accelerometer. Datasheet: >>>> >>http://www.freescale.com.cn/files/sensors/doc/data_sheet/MMA7660FC.pdf >>>> >>>> Includes: >>>> - ACPI support; >>>> - read_raw for x,y,z axes; >>>> - reading and setting the scale (range) parameter. >>>> - power management >>>> >>>> Signed-off-by: Constantin Musca <constantin.musca@xxxxxxxxx> >>> Couple of trivial bits inline as well as that request to update the >>link above >>> if possible... >>> >>> Why the retries? (I'm on a train without internet access for quite a >>few >>> hours yet hence I can't dig into the datasheet!) >> >>I suggested the retries because it's quite unsafe to infinitely loop >>in the kernel >>on a hardware condition. We can lockup the kernel if there is some sort >>of >>hardware problem. > Agreed but why try more than once? Needs a comment... >> >> >>> >>> Anyhow, even if it's obvious from the datasheet, that sort of 'magic' >>needs >>> an explanation comment... Agree we need a comment on that. As for the number of retries I can see drivers doing from 5 to 100 (re)tries: humidity/si7005.c 44: int tries = 50; 55: while (tries-- > 0) { temperature/tmp006.c 55: int tries = 50; 57: while (tries-- > 0) { dac/mcp4725.c 76: int tries = 20; 99: while (tries--) { 111: if (tries < 0) { pressure/mpl3115.c 49: int ret, tries = 15; 57: while (tries-- > 0) { ight/ltr501.c 329: int tries = 100; 332: while (tries--) { proximity/pulsedlight-lidar-lite-v2.c 160: int tries = 10; accel/mma9551_core.c 75:#define MMA9551_I2C_READ_RETRIES 5 Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
