On Sun, May 01, 2016 at 06:11:50PM +0100, Jonathan Cameron wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > On 29/04/16 20:02, Crestez Dan Leonard wrote: > > Using regmap_read_bulk is wrong because it assumes that a range of > > registers is being read. In our case reading from the fifo register will > > return multiple values but this is *not* auto-increment. > > This currently works by accident. > Cc'd Mark again. He's the regmap maintainer (amongst other things) so > a series doing slightly odd things with regmap should probably have been > cc'd to him in the first place. > Perhaps regmap should have a repeat read function for this sort of fifo access? > Mark, is this something you'd consider? Easy enough to implement after all as > a variant on regmap_read_bulk... > Having the below in a driver just feels wrong to me.... That doesn't sound like a crazy idea, please send patches for proposed extensions.
Attachment:
signature.asc
Description: PGP signature
