My understanding from the previous commits is that it might be NULL when enumerating via ACPI (I didn't dig into core to check this so I'm not able to confirm if that is still the case). (commit: 4f33fbae555000bf73aaacbc4f5b24668afc8c7a) On Sat, Mar 5, 2016 at 7:50 PM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > On 02/03/16 22:04, Matt Ranostay wrote: >> Will fix and submit this afternoon! >> >> Sent from my iPhone >> >>> On Mar 2, 2016, at 10:21, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: >>> >>> I sent that too quickly. The i2c version of inv_mpu_probe() has the >>> same issue as well. >>> >>> drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c:134 inv_mpu_probe() >>> error: we previously assumed 'id' could be null (see line 119) >>> >>> regards, >>> dan carpenter > Whilst true, I'm now wondering why we assumed it might be. Paranoia perhaps? > Hmm, guess we should keep it consistent (he says having just bounced this > back to Matt)- I'll take it as is but as a cleanup rather than a fix. > > J >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >>> the body of a message to majordomo@xxxxxxxxxxxxxxx >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
