On 03/03/16 10:44, Gregor Boirie wrote:
> ak_def_array bounds are not properly checked in case of ACPI matching
> failure. GCC warns with the following message at line 799:
> ‘chipset’ may be used uninitialized in this function.
>
> Signed-off-by: Gregor Boirie <gregor.boirie@xxxxxxxxxx>
Applied.
> ---
> drivers/iio/magnetometer/ak8975.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
> index 9c5c9ef..11059b2 100644
> --- a/drivers/iio/magnetometer/ak8975.c
> +++ b/drivers/iio/magnetometer/ak8975.c
> @@ -774,8 +774,11 @@ static int ak8975_probe(struct i2c_client *client,
> if (id) {
> chipset = (enum asahi_compass_chipset)(id->driver_data);
> name = id->name;
> - } else if (ACPI_HANDLE(&client->dev))
> + } else if (ACPI_HANDLE(&client->dev)) {
> name = ak8975_match_acpi_device(&client->dev, &chipset);
> + if (!name)
> + return -ENODEV;
> + }
> else
> return -ENOSYS;
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
