On 02/22/2016 08:14 PM, Harald Geyer wrote:
Hi Gregor!
Hi Harald,
[snip]
drivers/iio/humidity/dht11.c | 16 +-
The dht11 driver only uses timestamps internally. AFAICT they are not
exported to user space, so there is little point in making the clock
selectable.
Ok. It seems no timestamping channel / events is exposed anyway: I
suppose it
makes no sense to use the timestamping clock API in this case.
What's more important: The timestamps are used to decide the validity
of cached values. I think your change introduces a bug where the driver
could report outdated (or even uninitialized) values to user space.
(Actually we switched the driver to monotonic time just recently to fix
this.)
I guess I should leave the dht11 driver completly untouched in my patch
then.
Thanks for the quick feedback :)
[snip]
Regards,
Grégor.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
