Re: [PATCH] iio: chemical: atlas-ph-sensor: switch regmap cache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 14, 2016 at 06:40:15PM +0100, Lars-Peter Clausen wrote:
> On 02/14/2016 04:02 PM, Jonathan Cameron wrote:

> > I'm lost here. Why should changing the storage of the register cache result
> > in different behaviour other than in efficiency of access to cached values?

> And if there is really a difference this should probably be addressed at the
> regmap level.

You'd need to make regcache-flat keep track of which cache values are
valid either during init (in which case it'd have to read every other
register at that time) or at runtime (which would mean extra operations
in a fast path).  Flat really is special here, there's no reason to use
it over a rbtree other than being very sensitive about performance.

Please also be aware that if you CC me on an iio patch series there's a
good chance I'll just delete it without reading it, for some reason I
keep on getting copied on lots of them which have no relevance to me
that I'm able to identify.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux