On Sat, Feb 06, 2016 at 06:30:04PM +0000, Jonathan Cameron wrote: > On 03/02/16 14:31, Sean Nyekjaer wrote: > > Signed-off-by: Sean Nyekjaer <sean.nyekjaer@xxxxxxxxx> > Hmm. Complex beast. Going to want Lars to look at this in particular. > Also a device tree review would be good on this one. > > My personal gut feeling is not to wrap up things that are really numeric > with names, but rather to provide docs on the valid values for them. > Not sure what is the preferred by the device tree guys?? Agreed. I'm not such a fan of defines in DT. Also, if there is some possibility that bindings could be generic, I prefer to see them use the native units rather than the enumerated register values. The downside is adding the translation into the driver. These look like they could possibly be generic DAC properties. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
