On Sat, Aug 29, 2015 at 12:59 AM, Hartmut Knaack <knaack.h@xxxxxx> wrote: > The regulator framework requests to balance regulator_enable() calls with > regulator_disable() calls. To meet this requirement, set channels to 0 on > remove, which implies a regulator_disable() call in case that channel was > enabled. > > Signed-off-by: Hartmut Knaack <knaack.h@xxxxxx> Acked-by: Daniel Baluta <daniel.baluta@xxxxxxxxx> > --- > drivers/iio/dac/m62332.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iio/dac/m62332.c b/drivers/iio/dac/m62332.c > index cffc0630ed32..c61720de8606 100644 > --- a/drivers/iio/dac/m62332.c > +++ b/drivers/iio/dac/m62332.c > @@ -243,6 +243,8 @@ static int m62332_remove(struct i2c_client *client) > > iio_device_unregister(indio_dev); > iio_map_array_unregister(indio_dev); > + m62332_set_value(indio_dev, 0, 0); > + m62332_set_value(indio_dev, 0, 1); > > return 0; > } Wouldn't be nice to factor this two calls in a separate function? thanks, Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
