On Wed, Aug 12, 2015 at 12:51:36PM +0100, Mark Brown wrote:
> On Wed, Aug 12, 2015 at 12:12:38PM +0200, Markus Pargmann wrote:
> > Signed-off-by: Markus Pargmann <mpa@xxxxxxxxxxxxxx>
>
> Your changelog doesn't mention why anything would reasonably want to use
> this and...
Right, this is used later in the driver code of bmc150 to find out how
much we can read from the sensor in one run.
>
> > +size_t regmap_get_raw_io_max(struct regmap *map)
> > +{
> > + return map->max_raw_io;
> > +}
> > +EXPORT_SYMBOL_GPL(regmap_get_raw_io_max);
> > +
> > +/**
> > + * regmap_get_raw_read_max - Get the maximum size we can read
> > + *
> > + * @map: Map to check.
> > + */
>
> ...it is adding two functions which don't seem very symmetrically named.
Oh, this is half of my previous version where raw_read_max and
raw_write_max where separate. Will fix it along with your comment that
these should be different values for read and write.
Thanks,
Markus
>
> > @@ -441,6 +441,8 @@ int regmap_get_max_register(struct regmap *map);
> > int regmap_get_reg_stride(struct regmap *map);
> > int regmap_async_complete(struct regmap *map);
> > bool regmap_can_raw_write(struct regmap *map);
> > +size_t regmap_get_raw_write_max(struct regmap *map);
> > +size_t regmap_get_raw_io_max(struct regmap *map);
>
> Do we want stubs here?
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: Digital signature
