Breana, Tiberiu A schrieb am 28.07.2015 um 15:45: >> -----Original Message----- >> From: Hartmut Knaack [mailto:knaack.h@xxxxxx] >> Sent: Tuesday, July 28, 2015 1:49 AM >> To: linux-iio@xxxxxxxxxxxxxxx >> Cc: Jonathan Cameron; Lars-Peter Clausen; Peter Meerwald; Breana, Tiberiu >> A >> Subject: [PATCH 6/7] iio:accel:stk8312: code style cleanup >> >> Adjust some indentation issues to make checkpatch.pl happy in strict mode. >> >> Signed-off-by: Hartmut Knaack <knaack.h@xxxxxx> > > Comment inline. > >> --- >> drivers/iio/accel/stk8312.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/iio/accel/stk8312.c b/drivers/iio/accel/stk8312.c index >> e3624e2b3ec4..b059a6cabfbb 100644 >> --- a/drivers/iio/accel/stk8312.c >> +++ b/drivers/iio/accel/stk8312.c >> @@ -157,8 +157,7 @@ static int stk8312_otp_init(struct stk8312_data *data) >> if (ret < 0) >> goto exit_err; >> >> - ret = i2c_smbus_write_byte_data(data->client, >> - STK8312_REG_AFECTRL, ret); >> + ret = i2c_smbus_write_byte_data(data->client, >> STK8312_REG_AFECTRL, >> +ret); > > On a single line, this write op would take up 81 chars. > I think it's best to just add 2 tabs to the 2nd line. > Don't worry, it is 80 chars sharp. I have double checked, even checkpatch.pl in strict mode doesn't complain on this one. Just on 2 other points, which I don't consider essential. Thanks, Hartmut >> if (ret < 0) >> goto exit_err; >> msleep(150); >> @@ -453,7 +452,7 @@ static irqreturn_t stk8312_trigger_handler(int irq, void >> *p) >> data->buffer[2] = buffer[2]; >> } else { >> for_each_set_bit(bit, indio_dev->active_scan_mask, >> - indio_dev->masklength) { >> + indio_dev->masklength) { >> ret = stk8312_read_accel(data, bit); >> if (ret < 0) { >> mutex_unlock(&data->lock); >> -- >> 2.4.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
