Hi, On Sun, Jul 26, 2015 at 12:43:21AM +0200, Hartmut Knaack wrote: > Make use of GENMASK for consecutive bitmasks and BIT for single bitmasks. Thanks for doing this clean-up. > Signed-off-by: Hartmut Knaack <knaack.h@xxxxxx> > --- > @@ -50,7 +50,7 @@ > #define BERLIN2_SM_CTRL_TSEN_MODE_10_50 (0x1 << 22) /* 10-50 C */ > #define BERLIN2_SM_CTRL_TSEN_RESET BIT(29) > #define BERLIN2_SM_ADC_DATA 0x20 > -#define BERLIN2_SM_ADC_MASK 0x3ff > +#define BERLIN2_SM_ADC_MASK GENMASK(9, 0) > #define BERLIN2_SM_ADC_STATUS 0x1c > #define BERLIN2_SM_ADC_STATUS_DATA_RDY(x) BIT(x) /* 0-15 */ > #define BERLIN2_SM_ADC_STATUS_DATA_RDY_MASK GENMASK(15, 0) > @@ -60,14 +60,14 @@ > #define BERLIN2_SM_TSEN_STATUS_DATA_RDY BIT(0) > #define BERLIN2_SM_TSEN_STATUS_INT_EN BIT(1) > #define BERLIN2_SM_TSEN_DATA 0x28 > -#define BERLIN2_SM_TSEN_MASK 0xfff There was actually an error here. It should have been 0x3ff as BERLIN2_SM_ADC_MASK. > +#define BERLIN2_SM_TSEN_MASK GENMASK(11, 0) So, GENMASK(9, 0). Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
