> -----Original Message----- > From: Hartmut Knaack [mailto:knaack.h@xxxxxx] > Sent: 24 July, 2015 2:13 > To: Tirdea, Irina; Jonathan Cameron; linux-iio@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 2/2] tools: iio: print error message when buffer enable fails > > Irina Tirdea schrieb am 23.07.2015 um 19:22: > > Running generic_buffer without enabling any channel of the > > sensor will fail without printing any error message. > > > > Add an error message that indicates buffer enable failed. > > Hi, > please make use of the error code stored in ret (with negative sign), as > in most cases the value of errno has already changed since the original > error has occurred. > Thanks, > Hi Hartmut, Yes, you are right. Missed that. Will fix in v2. Thanks, Irina > Hartmut > > > > > Signed-off-by: Irina Tirdea <irina.tirdea@xxxxxxxxx> > > --- > > tools/iio/generic_buffer.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/tools/iio/generic_buffer.c b/tools/iio/generic_buffer.c > > index 32f389eb..936469c 100644 > > --- a/tools/iio/generic_buffer.c > > +++ b/tools/iio/generic_buffer.c > > @@ -364,8 +364,11 @@ int main(int argc, char **argv) > > > > /* Enable the buffer */ > > ret = write_sysfs_int("enable", buf_dir_name, 1); > > - if (ret < 0) > > + if (ret < 0) { > > + fprintf(stderr, > > + "Failed to enable buffer: %s\n", strerror(errno)); > > goto error_free_buf_dir_name; > > + } > > > > scan_size = size_from_channelarray(channels, num_channels); > > data = malloc(scan_size * buf_len); > > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
