Hi Daniel, 2015-07-21 13:23 GMT+02:00 Daniel Baluta <daniel.baluta@xxxxxxxxx>: > On Tue, Jul 21, 2015 at 2:08 PM, Giuseppe Barba > <giuseppe.barba@xxxxxxxxx> wrote: >> Hi Denis, >> >> thanks for review. >>> >>> Just add one blank line please, it was missing also before! >>> >>> Denis >> >> I'll add the missed blank line and push again the patch to you. > > Hi Giuseppe, > > Thanks a lot for your work :). One minor nit that could improve > reviews for your next patches. > > Please add modification history from version to version. This can be done > in the cover letter if you have multiple patches, or in the patch itself under > the scissor line. > > e.g. > [PATCH V2] iio: st: rework code style removing goto statements > > The scope of this patch is to remove some goto statements and its label > present into st sensors driver. > > Signed-off-by: Giuseppe Barba <giuseppe.barba@xxxxxx> > --- <this is scissor line> > Change since v1: > * added missing blank lines. > > thanks, > Daniel. Thanks for your hint. I'll do that next time. Regards Giuseppe. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html