On 19/07/15 16:24, Guenter Roeck wrote: > On Sun, Jul 19, 2015 at 10:24:53AM +0100, Jonathan Cameron wrote: >> On 19/07/15 04:04, Matt Ranostay wrote: >>> This changeset adds driver support for the Microchip mcp98xx series of >>> temperature sensors. >>> > > MCP98xx is pretty a pretty far reaching claim. This could also be MCP9804 > or MCP9843, which are JC42 compatible sensor chips and supported by the jc42 > driver. Does the new driver claim to support those as well ? Indeed. Generic driver names are almost always a bad idea! > > Guenter > >>> This includes temperature reading, and rising/falling threshold events. >> Why an IIO driver? These parts already look to be supported in hwmon by >> the lm75 driver. We need a pretty strong reason to contemplate having >> support in both subsystems... >>> >>> Matt Ranostay (2): >>> iio: temperature: DT binding doc for mcp98xx >>> iio: temperature: add support for mcp98xx sensors >>> >>> .../bindings/iio/temperature/mcp98xx.txt | 22 + >>> drivers/iio/temperature/Kconfig | 10 + >>> drivers/iio/temperature/Makefile | 1 + >>> drivers/iio/temperature/mcp98xx.c | 588 +++++++++++++++++++++ >>> 4 files changed, 621 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/iio/temperature/mcp98xx.txt >>> create mode 100644 drivers/iio/temperature/mcp98xx.c >>> >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html