On Tue, Jul 7, 2015 at 1:46 AM, Cristina Opriceana <cristina.opriceana@xxxxxxxxx> wrote: > This patchset indends to make some cleanup and send printf > error messages to stderr. > The changes were performed with coccinelle for failiure > messages and manual for other cases. The following script > was used: > > @r@ > expression e1, e2, stdout; > @@ > (printf(e1); > | > printf(e1, e2); > | > fprintf(stdout, e1); > | > fprintf(stdout, e1, e2); > ) > @script: python get_string@ > e << r.e1; > tdres; > @@ > if 'could not' in e.lower() or 'fail' in e.lower() \ > or 'problem' in e.lower() or 'not set' in e.lower(): > coccinelle.tdres = e > else: > cocci.include_match(False) > @r_match@ > expression r.stdout, r.e1, r.e2; > identifier get_string.tdres; > @@ > ( > - printf(e1); > + fprintf(stderr, tdres); > | > - printf(e1, e2); > + fprintf(stderr, tdres, e2); > | > - fprintf(stdout, e1) > + fprintf(stderr, tdres) > | > - fprintf(stdout, e1, e2) > + fprintf(stderr, tdres, e2) > ) Nit: s/failiure/failure this appears in several places. With this fixed: Reviewed-by: Daniel Baluta <daniel.baluta@xxxxxxxxx> thanks, Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html