On Sun, 05 Jul 2015 13:15:38 +0100, Jonathan Cameron <jic23@xxxxxxxxxx>
wrote:
> On 30/06/15 20:37, harald@xxxxxxxxx wrote:
>> Thanks for pointing out --strict - didn't know about that yet.
>>
>> I get the following output:
>>
>> CHECK: spaces preferred around that '*' (ctx:VxV)
>> #96: FILE: drivers/iio/humidity/dht11.c:167:
>> + if (DHT11_DATA_BIT_HIGH < 2*timeres) {
>> ^
>>
>> With this one I disagree. Omitting the spaces makes the code easier to
>> read, because it reflects the relative binding power of operators
>> involed.
>> This style (omitting spaces around * if there is a +, <, etc in the
same
>> experession) is used throughout the driver. I'd change this only if
there
>> is consensus, that this really is the preferred way.
> Personal taste wise I agree with you, but conventions are conventions
> and the kernel way is spaces around binary operators to distinguish them
> from unary operators...
>
> I'll only get a newbie patch 'fixing' this otherwise, so please do
change
> it!
Of course you have the last word on this. As long as the newbies are
competent enough to really only do whitespace changes, I'd be tempted
to wait for them to do the work. Alas I really want the original patch
merged soon so I will do the obfuscation myself.
Thanks,
Harald the newbie :)
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
