Daniel Baluta schrieb am 29.06.2015 um 09:57: > On Sun, Jun 28, 2015 at 1:31 PM, Hartmut Knaack <knaack.h@xxxxxx> wrote: >> When filling data->als_contr, the register content read into status needs >> to be used, instead of the return status value of regmap_read. >> >> This fixes: 8592a7eefa540303dd9e60fa49340d09ca9376b4 >> "iio: ltr501: Add support for ltr559 chip" >> > > Ditto, as per previous patch: > > Fixes: 8592a7eefa540 ("iio: ltr501: Add support for ltr559 chip") > > Also, I'm pretty sure that checkpatch.pl should have warned you about > this. > Unfortunately it doesn't. But I will keep it in mind. >> Signed-off-by: Hartmut Knaack <knaack.h@xxxxxx> >> --- >> drivers/iio/light/ltr501.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c >> index 1ef7d37..b5a0e66 100644 >> --- a/drivers/iio/light/ltr501.c >> +++ b/drivers/iio/light/ltr501.c >> @@ -1302,7 +1302,7 @@ static int ltr501_init(struct ltr501_data *data) >> if (ret < 0) >> return ret; >> >> - data->als_contr = ret | data->chip_info->als_mode_active; >> + data->als_contr = status | data->chip_info->als_mode_active; >> >> ret = regmap_read(data->regmap, LTR501_PS_CONTR, &status); >> if (ret < 0) >> -- >> 2.3.6 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html