On Wed, Jun 17, 2015 at 1:17 AM, Hartmut Knaack <knaack.h@xxxxxx> wrote: > cm3323_get_it_bits() returns a valid error code, so pass it up in > cm3323_read_raw(). > > Signed-off-by: Hartmut Knaack <knaack.h@xxxxxx> Agree, it's better this way. Reviewed-by: Daniel Baluta <daniel.baluta@xxxxxxxxx> > --- > drivers/iio/light/cm3323.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/light/cm3323.c b/drivers/iio/light/cm3323.c > index 1e6092a..f88a0ed 100644 > --- a/drivers/iio/light/cm3323.c > +++ b/drivers/iio/light/cm3323.c > @@ -175,7 +175,7 @@ static int cm3323_read_raw(struct iio_dev *indio_dev, > i = cm3323_get_it_bits(data); > if (i < 0) { > mutex_unlock(&data->mutex); > - return -EINVAL; > + return i; > } > > *val = cm3323_int_time[i].val; > -- > 2.3.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html