On Mon, Jun 15, 2015 at 2:39 AM, Peter Meerwald <pmeerw@xxxxxxxxxx> wrote:
> the millisecond values in tcs3414_times should be checked against
> val2, not val, which is always zero.
nit :
may be the variable name could be little more descriptive.
>
> Signed-off-by: Peter Meerwald <pmeerw@xxxxxxxxxx>
> Reported-by: Stephan Kleisinger <stephan.kleisinger@xxxxxxxxx>
> ---
> drivers/iio/light/tcs3414.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/tcs3414.c b/drivers/iio/light/tcs3414.c
> index 71c2bde..f8b1df0 100644
> --- a/drivers/iio/light/tcs3414.c
> +++ b/drivers/iio/light/tcs3414.c
> @@ -185,7 +185,7 @@ static int tcs3414_write_raw(struct iio_dev *indio_dev,
> if (val != 0)
> return -EINVAL;
> for (i = 0; i < ARRAY_SIZE(tcs3414_times); i++) {
> - if (val == tcs3414_times[i] * 1000) {
> + if (val2 == tcs3414_times[i] * 1000) {
> data->timing &= ~TCS3414_INTEG_MASK;
> data->timing |= i;
> return i2c_smbus_write_byte_data(
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
