Re: [PATCH v2 1/3] tools:iio:iio_event_monitor: check if event is fully read

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 10, 2015 at 10:51 PM, Hartmut Knaack <knaack.h@xxxxxx> wrote:
> Check that the read event is of the expected size.
>
> Signed-off-by: Hartmut Knaack <knaack.h@xxxxxx>
> ---
>  tools/iio/iio_event_monitor.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/tools/iio/iio_event_monitor.c b/tools/iio/iio_event_monitor.c
> index 016760e..2559fba 100644
> --- a/tools/iio/iio_event_monitor.c
> +++ b/tools/iio/iio_event_monitor.c
> @@ -299,6 +299,12 @@ int main(int argc, char **argv)
>                         }
>                 }
>
> +               if (ret != sizeof(event)) {
> +                       printf("Reading event failed!\n");
> +                       ret = -EIO;
> +                       break;
> +               }
> +

For a test program this should be good enough, not sure if it does make sense
to read until we get all data.

Also, we should print the error at stderr.

>                 print_event(&event);
>         }

thanks,
Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux