Re: [PATCH 01/32] tools:iio:generic_buffer: fix order of freeing data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 31/05/15 13:39, Hartmut Knaack wrote:
> data gets allocated before buffer_access, so it should be freed in reverse
> order. Otherwise, if allocating buffer_access fails, an attempt to free it
> would be taken, which should not happen.
> 
> Signed-off-by: Hartmut Knaack <knaack.h@xxxxxx>
Applied to the togreg branch of iio.git which will get pushed out as
testing when I'm on a sensible net connection.

An unplanned work trip for the next few days (hopefully not longer).

Jonathan
> ---
>  tools/iio/generic_buffer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/iio/generic_buffer.c b/tools/iio/generic_buffer.c
> index f805493..15f2a40 100644
> --- a/tools/iio/generic_buffer.c
> +++ b/tools/iio/generic_buffer.c
> @@ -345,10 +345,10 @@ int main(int argc, char **argv)
>  
>  error_close_buffer_access:
>  	close(fp);
> -error_free_data:
> -	free(data);
>  error_free_buffer_access:
>  	free(buffer_access);
> +error_free_data:
> +	free(data);
>  error_free_buf_dir_name:
>  	free(buf_dir_name);
>  error_free_triggername:
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux