> From: Dan Carpenter [mailto:dan.carpenter@xxxxxxxxxx] > Sent: Wednesday, May 27, 2015 11:24 AM > To: Jonathan Cameron > Cc: Hartmut Knaack; Lars-Peter Clausen; Peter Meerwald; Breana, Tiberiu A; > linux-iio@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx > Subject: [patch] iio: light: signedness bug in stk3310_write_raw() > > "index" needs to be signed for the error handling to work. > Thanks for this. I don't know how it slipped by our reviews. Reviewed-by: Tiberiu Breana <tiberiu.a.breana@xxxxxxxxx> > Fixes: be9e6229d676 ('iio: light: Add support for Sensortek STK3310') > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c index > e79b9d8..fee4297 100644 > --- a/drivers/iio/light/stk3310.c > +++ b/drivers/iio/light/stk3310.c > @@ -370,7 +370,7 @@ static int stk3310_write_raw(struct iio_dev > *indio_dev, > int val, int val2, long mask) > { > int ret; > - unsigned int index; > + int index; > struct stk3310_data *data = iio_priv(indio_dev); > > switch (mask) { -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
