On 08/05/15 19:54, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
>
> Using devm_iio_device_register() can make the code shorter and cleaner.
... and totally changes the order of the remove function by making it remove
the userspace interface, after a whole load of other elements are destroyed.
This adds one heck of a race condition. devm_iio_device_register
is pretty much only safe if it allows the remove function to be completely
empty and hence dropped.
Jonathan
>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> ---
> drivers/iio/light/hid-sensor-prox.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/iio/light/hid-sensor-prox.c b/drivers/iio/light/hid-sensor-prox.c
> index 4ed42df..c9f804b 100644
> --- a/drivers/iio/light/hid-sensor-prox.c
> +++ b/drivers/iio/light/hid-sensor-prox.c
> @@ -306,7 +306,7 @@ static int hid_prox_probe(struct platform_device *pdev)
> goto error_unreg_buffer_funcs;
> }
>
> - ret = iio_device_register(indio_dev);
> + ret = devm_iio_device_register(&pdev->dev, indio_dev);
> if (ret) {
> dev_err(&pdev->dev, "device register failed\n");
> goto error_remove_trigger;
> @@ -319,13 +319,11 @@ static int hid_prox_probe(struct platform_device *pdev)
> &prox_state->callbacks);
> if (ret < 0) {
> dev_err(&pdev->dev, "callback reg failed\n");
> - goto error_iio_unreg;
> + return ret;
> }
>
> - return ret;
> + return 0;
>
> -error_iio_unreg:
> - iio_device_unregister(indio_dev);
> error_remove_trigger:
> hid_sensor_remove_trigger(&prox_state->common_attributes);
> error_unreg_buffer_funcs:
> @@ -343,7 +341,6 @@ static int hid_prox_remove(struct platform_device *pdev)
> struct prox_state *prox_state = iio_priv(indio_dev);
>
> sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_PROX);
> - iio_device_unregister(indio_dev);
> hid_sensor_remove_trigger(&prox_state->common_attributes);
> iio_triggered_buffer_cleanup(indio_dev);
> kfree(indio_dev->channels);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
