On Thu, May 7, 2015 at 7:15 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote: > On Thu, May 7, 2015 at 6:51 PM, Srinivas Pandruvada > <srinivas.pandruvada@xxxxxxxxxxxxxxx> wrote: >> On Thu, 2015-05-07 at 11:09 -0300, Fabio Estevam wrote: >>> 'channels' is allocated via kmemdup, so we need to free it after its usage. >>> >>> This way we fix the memory leak in both probe and remove paths. >>> >>> Also, as 'indio_dev' is allocated via devm_iio_device_alloc(), so there is >>> no need to call kfree for it. >> Where is the kfree for indio_dev..? > > It is kfree(indio_dev->channels) actually. > >>> >>> Reported-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx> >>> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> >>> --- >>> Changes since v1: >>> - Always call kfree(channel) after its usage. >>> >>> drivers/iio/light/hid-sensor-prox.c | 14 ++++++-------- >>> 1 file changed, 6 insertions(+), 8 deletions(-) >>> >>> diff --git a/drivers/iio/light/hid-sensor-prox.c b/drivers/iio/light/hid-sensor-prox.c >>> index 91ecc46..00ce0f6 100644 >>> --- a/drivers/iio/light/hid-sensor-prox.c >>> +++ b/drivers/iio/light/hid-sensor-prox.c >>> @@ -278,16 +278,17 @@ static int hid_prox_probe(struct platform_device *pdev) >>> return -ENOMEM; >>> } >>> >>> + indio_dev->channels = channels; >>> + >>> ret = prox_parse_report(pdev, hsdev, channels, >>> HID_USAGE_SENSOR_PROX, prox_state); >>> + kfree(channels); >> You are freeing channels so indio_dev->channels will point to junk. >> This will be passed to iio_device_register.. > > No, I am freeing channels, not indio_dev->channels. Ops, I see the issue. I think it is better if we go with the v1 instead. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
