On Wed, May 6, 2015 at 7:14 PM, Alexey Khoroshilov <khoroshilov@xxxxxxxxx> wrote: > Not exactly. Other calls are after > indio_dev->channels = channels; > So, > error_free_dev_mem: > kfree(indio_dev->channels); > works for them well. indio_dev is allocated using devm_ , so you don't need to free it. Your patch is not correct because you only kfree(channels) in the prox_parse_report() error case, but you missed the other subsequent functions. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html